Fixed chart crashing bug on enabling multiple shapes with multiple legends selected #33221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anush <[email protected]>
Co-authored-by: Anush <[email protected]>
…luentui into usr/atisjai/chartsV9
…luentui into usr/atisjai/chartsV9
AtishayMsft
requested review from
AtishayMsft
and removed request for
a team
AtishayMsft
reviewed
Nov 11, 2024
| @@ -184,7 +184,6 @@ export const LineChart: React.FunctionComponent<LineChartProps> = React.forwardR | |||
| }, [props.height, props.width, props.data]); | |||
|
|
|||
| function _injectIndexPropertyInLineChartData(lineChartData?: LineChartPoints[]): LineChartDataWithIndex[] | [] { | |||
| const { allowMultipleShapesForPoints = false } = props; | |||
There was a problem hiding this comment.
what is this change? Not using enable multiple shape prop anymore?
There was a problem hiding this comment.
allowMultipleShapesForPoints is used as it is in _createLegends,_getBoxWidthOfShape,_getPath,_getPointFill functions. Within _injectIndexPropertyInLineChartData function, the index of the selection was earlier passed based on allowMultipleShapesForPoints prop. If allowMultipleShapesForPoints was true, index was passed as -1 which was causing the crash at _createLines function where it was getting index of point as -1.
tudorpopams
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed chart crashing bug on enabling multiple shapes with multiple legends selected
[V9] [Doc site] when we select more than 3 legends and enable on multiple shapes getting an error as Cannot read properties of undefined.